mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 48802: Added a metrics prefix for registrar replicated log.
Date Thu, 16 Jun 2016 21:54:37 GMT


> On June 16, 2016, 9:19 p.m., Joseph Wu wrote:
> > src/master/main.cpp, line 416
> > <https://reviews.apache.org/r/48802/diff/1/?file=1421644#file1421644line416>
> >
> >     With this, the metric name becomes `registrarlog/recovered`.  Maybe use `registrar/`
instead?

Thanks! Good catch!


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48802/#review138087
-----------------------------------------------------------


On June 16, 2016, 5:29 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48802/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 5:29 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5618
>     https://issues.apache.org/jira/browse/MESOS-5618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a metrics prefix for registrar replicated log.
> 
> 
> Diffs
> -----
> 
>   src/local/local.cpp 8f84b54505ad07d60c9bebc15b7d2fe1f9ab080a 
>   src/master/main.cpp 91632051b1148f1a9c7e6fc29fe73fcbd019618a 
> 
> Diff: https://reviews.apache.org/r/48802/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message