mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 48803: Added a test for replicated log metrics.
Date Thu, 16 Jun 2016 21:47:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48803/#review138075
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/log_tests.cpp (line 2086)
<https://reviews.apache.org/r/48803/#comment203283>

    Can you add an `ASSERT_SOME` here?  Presumably, you want to make sure the replica is in
a `VOTING` state.
    
    I added the same assert for the existing tests here: https://reviews.apache.org/r/48571/



src/tests/log_tests.cpp (lines 2088 - 2089)
<https://reviews.apache.org/r/48803/#comment203311>

    Add a "not-recovered" check here.
    
    ```
    ASSERT_EQ(1u, snapshot.values.count("prefix/log/recovered"));
    EXPECT_EQ(0, snapshot.values["prefix/log/recovered"]);
    ```


- Joseph Wu


On June 16, 2016, 10:29 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48803/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 10:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5618
>     https://issues.apache.org/jira/browse/MESOS-5618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test for replicated log metrics.
> 
> 
> Diffs
> -----
> 
>   src/tests/log_tests.cpp 06bf5b8eb0336e015285ef749f50b8ad5be9aa62 
> 
> Diff: https://reviews.apache.org/r/48803/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message