mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 48802: Added a metrics prefix for registrar replicated log.
Date Thu, 16 Jun 2016 21:19:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48802/#review138087
-----------------------------------------------------------


Fix it, then Ship it!




Can you add a patch to update the monitoring doc with the new metric?

This seems like a good spot:
https://github.com/apache/mesos/blame/2a02d8bfcbf50778b7180fe0aaa22bbdfcdb4097/docs/monitoring.md#L246-L259


src/master/main.cpp (line 416)
<https://reviews.apache.org/r/48802/#comment203303>

    With this, the metric name becomes `registrarlog/recovered`.  Maybe use `registrar/` instead?


- Joseph Wu


On June 16, 2016, 10:29 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48802/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 10:29 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5618
>     https://issues.apache.org/jira/browse/MESOS-5618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a metrics prefix for registrar replicated log.
> 
> 
> Diffs
> -----
> 
>   src/local/local.cpp 8f84b54505ad07d60c9bebc15b7d2fe1f9ab080a 
>   src/master/main.cpp 91632051b1148f1a9c7e6fc29fe73fcbd019618a 
> 
> Diff: https://reviews.apache.org/r/48802/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message