mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48365: Bundled NVML headers for Nvidia GPU support.
Date Thu, 16 Jun 2016 20:06:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48365/#review138065
-----------------------------------------------------------


Ship it!




This is coming together very nicely!

Now we can build it without external depedencies and we'll pick up the dependency at runtime.
Are you planning to flip the configure default to have the nvidia code enabled by default?
That would be great!


configure.ac (line 341)
<https://reviews.apache.org/r/48365/#comment203271>

    Weird whitespace here?


- Benjamin Mahler


On June 11, 2016, 3:37 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48365/
> -----------------------------------------------------------
> 
> (Updated June 11, 2016, 3:37 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-5552
>     https://issues.apache.org/jira/browse/MESOS-5552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Bundled NVML headers for Nvidia GPU support.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3622602 
>   3rdparty/Makefile.am fb4a37d 
>   3rdparty/cmake/Versions.cmake 86c51ed 
>   3rdparty/nvml-352.79.tar.gz PRE-CREATION 
>   3rdparty/versions.am 7dcd6bf 
>   configure.ac e344c56 
>   src/Makefile.am b656702 
>   support/install-nvidia-gdk.sh fcb075f 
> 
> Diff: https://reviews.apache.org/r/48365/diff/
> 
> 
> Testing
> -------
> 
> GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message