mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48601: Exposed metrics information via `process::metrics::snapshot`.
Date Thu, 16 Jun 2016 17:58:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48601/
-----------------------------------------------------------

(Updated June 16, 2016, 5:58 p.m.)


Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo, Michael Park,
and Vinod Kone.


Changes
-------

Add performance test result.


Bugs: MESOS-5484
    https://issues.apache.org/jira/browse/MESOS-5484


Repository: mesos


Description
-------

Exposed metrics information via `process::metrics::snapshot`.


Diffs
-----

  3rdparty/libprocess/include/process/metrics/metrics.hpp 25e8fcaeb9c71eaa43096165745e79c8198c139a

  3rdparty/libprocess/src/metrics/metrics.cpp be03406c58439b7ab7c1ba12c19dd9f30aff109e 

Diff: https://reviews.apache.org/r/48601/diff/


Testing (updated)
-------

## Performance test:

I start a master and three agents in my test server. Use 

```
$ time for i in {1..200}; do curl 'http://localhost:5050/metrics/snapshot' -o /dev/null 2>/dev/null;
done
```

to collect the performance data.

Before apply this patch
```
real    1m39.684s
user    0m0.622s
sys     0m0.776s
```

After apply this patch
```
real    1m39.674s
user    0m0.586s
sys     0m0.817s
```


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message