mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48737: Added comments for `Call::SET_LOGGING_LEVEL`.
Date Thu, 16 Jun 2016 17:17:21 GMT


> On June 15, 2016, 9:10 p.m., Vinod Kone wrote:
> > include/mesos/agent/agent.proto, lines 61-64
> > <https://reviews.apache.org/r/48737/diff/2/?file=1420221#file1420221line61>
> >
> >     nice comment!

LoL, I copy the comment from `Logging::TOGGLE_HELP()`.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48737/#review137847
-----------------------------------------------------------


On June 16, 2016, 5:17 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48737/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 5:17 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5486
>     https://issues.apache.org/jira/browse/MESOS-5486
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added comments for `Call::SET_LOGGING_LEVEL`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto PRE-CREATION 
>   include/mesos/master/master.proto PRE-CREATION 
>   include/mesos/v1/agent/agent.proto b9b1680afec4e73c31a9e0aeb74153d129c54ee6 
>   include/mesos/v1/master/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
> 
> Diff: https://reviews.apache.org/r/48737/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message