mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 48789: Added tests for sandbox authorization.
Date Thu, 16 Jun 2016 16:58:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48789/#review138014
-----------------------------------------------------------


Fix it, then Ship it!




Will fix while committing.


src/tests/authorization_tests.cpp (line 2134)
<https://reviews.apache.org/r/48789/#comment203224>

    s/executors/sandboxes/



src/tests/authorization_tests.cpp (line 2144)
<https://reviews.apache.org/r/48789/#comment203226>

    not null?



src/tests/authorization_tests.cpp (line 2145)
<https://reviews.apache.org/r/48789/#comment203231>

    s/generic/not mentioned in the ACLs/



src/tests/authorization_tests.cpp (line 2214)
<https://reviews.apache.org/r/48789/#comment203234>

    s/acces/access/g



src/tests/authorization_tests.cpp (line 2228)
<https://reviews.apache.org/r/48789/#comment203236>

    one space less



src/tests/authorization_tests.cpp (line 2242)
<https://reviews.apache.org/r/48789/#comment203238>

    s/a//



src/tests/authorization_tests.cpp (line 2243)
<https://reviews.apache.org/r/48789/#comment203237>

    s/awithout/without/
    s/nd/and/


- Till Toenshoff


On June 16, 2016, 1:01 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48789/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 1:01 p.m.)
> 
> 
> Review request for mesos, Adam B and Till Toenshoff.
> 
> 
> Bugs: MESOS-5615
>     https://issues.apache.org/jira/browse/MESOS-5615
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We add tests for checking whether the
> LocalAuthorizer authorizes sandbox access
> as expected. Furthermore we extend the
> 'Get_ExecutorInfo' test to check for correct
> copying of fields which are relevant to
> authorization.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp 217f36f38b589f6ee9df36c1c5d9b4fbb5b53033 
>   src/tests/slave_tests.cpp 7ba03e8c06b8aaac1e57124c257660acd8c1d78a 
> 
> Diff: https://reviews.apache.org/r/48789/diff/
> 
> 
> Testing
> -------
> 
> make check + repeat new tests * 100
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message