mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.
Date Thu, 16 Jun 2016 15:36:49 GMT


> On June 16, 2016, 10:03 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [48603, 48602, 48601, 48600, 48597, 48596, 48737, 48595, 48588,
48587, 48585, 48584, 48583]
> > 
> > Failed command: ./support/apply-review.sh -n -r 48601
> > 
> > Error:
> > 2016-06-16 10:03:55 URL:https://reviews.apache.org/r/48601/diff/raw/ [9056/9056]
-> "48601.patch" [1]
> > 3rdparty/libprocess/src/metrics/metrics.cpp:232:  Lines should be <= 80 characters
long  [whitespace/line_length] [2]
> > Total errors found: 1
> > Checking 2 files
> > 
> > Full log: https://builds.apache.org/job/mesos-reviewbot/13814/console

can you fix this @haosdent?


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48603/#review137950
-----------------------------------------------------------


On June 15, 2016, 4:28 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48603/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 4:28 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta, Anand Mazumdar, zhou xing, Jay Guo, and
Vinod Kone.
> 
> 
> Bugs: MESOS-5484
>     https://issues.apache.org/jira/browse/MESOS-5484
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented v1::agent::Call::GET_METRICS.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 93c23a0b31193b17acd09337337530e984803b48 
>   src/slave/slave.hpp ef171188afb7169e7f386547af9fa334a65374af 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48603/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message