mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 48767: WIP: Add log replica tests that exercise election retry logic.
Date Thu, 16 Jun 2016 11:20:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48767/#review137955
-----------------------------------------------------------



Patch looks great!

Reviews applied: [48571, 48572, 48573, 48574, 48753, 48752, 48767]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On June 16, 2016, 1:07 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48767/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 1:07 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Neil Conway.
> 
> 
> Bugs: MESOS-5576
>     https://issues.apache.org/jira/browse/MESOS-5576
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds tests which drop a quorum of each type of message passed during 
> leader election. The dropped messages prevent that phase of leader
> election from proceeding unless the message is resent.
> 
> 
> Diffs
> -----
> 
>   src/tests/log_tests.cpp 06bf5b8eb0336e015285ef749f50b8ad5be9aa62 
> 
> Diff: https://reviews.apache.org/r/48767/diff/
> 
> 
> Testing
> -------
> 
> make check 
> 
> Need to implement the retry logic and enable these new tests.
> Would be nice to parameterize the tests (only one statement differs in each).
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message