mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhou xing <xingz...@cn.ibm.com>
Subject Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.
Date Thu, 16 Jun 2016 01:50:34 GMT


> On 六月 16, 2016, 1:11 a.m., zhou xing wrote:
> > src/master/http.cpp, line 1371
> > <https://reviews.apache.org/r/48596/diff/4/?file=1420195#file1420195line1371>
> >
> >     for some of the set_xxx or update_xxx method, we do not need contentType, we
keep this param only for consistency?
> 
> haosdent huang wrote:
>     Yes, I think we could add `/* */` to contentType which similiar to
>     ```
>     Future<Response> Master::Http::frameworks(
>         const Request& request,
>         const Option<string>& /*principal*/) const
>     ```

yeap, that's better I think


- zhou


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48596/#review137901
-----------------------------------------------------------


On 六月 15, 2016, 5:14 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48596/
> -----------------------------------------------------------
> 
> (Updated 六月 15, 2016, 5:14 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5486
>     https://issues.apache.org/jira/browse/MESOS-5486
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented v1::master::Call::SET_LOGGING_LEVEL.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp db625f0d656f207a89fcc14b18ae2fc31d30e673 
>   src/master/master.hpp a0944ddccd3a4b33458cd2489bb5fcdbbdc55720 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48596/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message