mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48584: Added unversioned protos for master API.
Date Thu, 16 Jun 2016 01:36:43 GMT


> On June 15, 2016, 9:05 p.m., Vinod Kone wrote:
> > src/Makefile.am, line 220
> > <https://reviews.apache.org/r/48584/diff/3/?file=1419944#file1419944line220>
> >
> >     so the unversioned master.proto file is at `include/mesos/master/master.proto`
whereas the versioned one is at `include/mesos/v1/master.proto`. we should either move the
former to `include/mesos/master.proto` or the latter to `include/mesos/v1/master/master.proto`.
we originially put the versioned proto at v1/master.proto instead of v1/master/master.proto
because the base directory path indicated the API endpoint, but i'm ok moving it to v1/master/master.proto.
> >     
> >     same with agent.

Compare current protobuf folder structure,
```
include/mesos/v1/agent.proto
include/mesos/v1/master.proto
include/mesos/v1/mesos.proto
```
vs
```
include/mesos/v1/executor/executor.proto
include/mesos/v1/maintenance/maintenance.proto
include/mesos/v1/master/allocator.proto
include/mesos/v1/quota/quota.proto
include/mesos/v1/scheduler/scheduler.proto
```
I prefer move `include/mesos/v1/agent.proto` to `include/mesos/v1/agent/agent.proto`, `include/mesos/v1/master.proto`
to `include/mesos/v1/master/master.proto`.
Let me post a patch for this.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48584/#review137843
-----------------------------------------------------------


On June 15, 2016, 2:26 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48584/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 2:26 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
>     https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unversioned protos for master API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.hpp PRE-CREATION 
>   include/mesos/master/master.proto PRE-CREATION 
>   src/Makefile.am f672fc9d2b58e785c65e21a4e52c60c04ce2498a 
> 
> Diff: https://reviews.apache.org/r/48584/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message