mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48737: Added comments for `Call::SET_LOGGING_LEVEL`.
Date Wed, 15 Jun 2016 21:10:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48737/#review137847
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/agent/agent.proto (line 45)
<https://reviews.apache.org/r/48737/#comment203025>

    s/Set/See/ ?



include/mesos/agent/agent.proto (lines 61 - 64)
<https://reviews.apache.org/r/48737/#comment203026>

    nice comment!



include/mesos/master/master.proto (line 51)
<https://reviews.apache.org/r/48737/#comment203028>

    s/Set/See/



include/mesos/v1/agent.proto (line 45)
<https://reviews.apache.org/r/48737/#comment203029>

    s/Set/See/



include/mesos/v1/master.proto (line 51)
<https://reviews.apache.org/r/48737/#comment203030>

    s/Set/See/


- Vinod Kone


On June 15, 2016, 5:32 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48737/
> -----------------------------------------------------------
> 
> (Updated June 15, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5486
>     https://issues.apache.org/jira/browse/MESOS-5486
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added comments for `Call::SET_LOGGING_LEVEL`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto PRE-CREATION 
>   include/mesos/master/master.proto PRE-CREATION 
>   include/mesos/v1/agent.proto b9b1680afec4e73c31a9e0aeb74153d129c54ee6 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
> 
> Diff: https://reviews.apache.org/r/48737/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message