mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.
Date Mon, 13 Jun 2016 22:29:05 GMT


> On June 13, 2016, 7:41 a.m., Neil Conway wrote:
> > src/tests/scheduler_http_api_tests.cpp, line 974
> > <https://reviews.apache.org/r/48614/diff/1/?file=1416557#file1416557line974>
> >
> >     Why are we fetching the stream ID?

looks like you forgot to set the stream ID header when sending the acknowledge call. if you
don't set it the BadRequest response might be due to the missing stream id and not malformed
uuid. after you fix this, make sure you set an expectation on the response body and not just
response status code.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48614/#review137239
-----------------------------------------------------------


On June 13, 2016, 6:51 a.m., Deshna Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48614/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 6:51 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5224
>     https://issues.apache.org/jira/browse/MESOS-5224
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds logic to the master/agent validation helpers
> to see if the status update acknowledgments have a valid UUID
> set conforming to one of the supported versions.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 309fbed81c9ff0ccc4ff4ee3ee70cf8f1fb2ac55 
>   src/slave/validation.cpp 189d10caf4517a1aff62b523d8eb99d9d1ca4b6a 
>   src/tests/scheduler_http_api_tests.cpp c12205f90e4f2da2c6ad7a0ea75777601eb0ef13 
> 
> Diff: https://reviews.apache.org/r/48614/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Deshna Jain
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message