mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 48587: Added unversioned protos for agent API.
Date Mon, 13 Jun 2016 20:18:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48587/#review137370
-----------------------------------------------------------



Can we name the unversioned proto file as just `agent.proto`? It would be good to not introduce
the `Slave` terminology going forward :-)


src/Makefile.am (line 1229)
<https://reviews.apache.org/r/48587/#comment202512>

    Nit: Alignment of ``.


- Anand Mazumdar


On June 12, 2016, 6:01 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48587/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 6:01 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.
> 
> 
> Bugs: MESOS-5593
>     https://issues.apache.org/jira/browse/MESOS-5593
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unversioned protos for agent API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/slave.hpp PRE-CREATION 
>   include/mesos/slave/slave.proto PRE-CREATION 
>   src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 
> 
> Diff: https://reviews.apache.org/r/48587/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message