mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 46762: Enabled volume support for mesos-execute.
Date Mon, 13 Jun 2016 15:27:12 GMT


> On 六月 12, 2016, 7:21 p.m., Jie Yu wrote:
> > src/cli/execute.cpp, lines 612-613
> > <https://reviews.apache.org/r/46762/diff/2/?file=1364750#file1364750line612>
> >
> >     Hum, any reason this is MesosContainerizer only?

This patch was created before https://reviews.apache.org/r/36440/ (Enabled docker volume support
for DockerContainerizer.), will update this part in next patch.


> On 六月 12, 2016, 7:21 p.m., Jie Yu wrote:
> > src/cli/execute.cpp, line 239
> > <https://reviews.apache.org/r/46762/diff/2/?file=1364750#file1364750line239>
> >
> >     Would love to support JSON::Array parsing. Right now, i think in only support
JSON::Object parsing. See here:
> >     https://github.com/apache/mesos/blob/master/3rdparty/stout/include/stout/flags/parse.hpp#L80

I saw that the executor command is using https://github.com/apache/mesos/blob/master/src/common/parse.hpp#L93
to handle `environment`, perhaps we can put the logic of `JSON::Array parsing` to  https://github.com/apache/mesos/blob/master/src/common/parse.hpp
?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46762/#review137199
-----------------------------------------------------------


On 四月 28, 2016, 1:56 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46762/
> -----------------------------------------------------------
> 
> (Updated 四月 28, 2016, 1:56 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5265
>     https://issues.apache.org/jira/browse/MESOS-5265
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Enabled volume support for mesos-execute.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
> 
> Diff: https://reviews.apache.org/r/46762/diff/
> 
> 
> Testing
> -------
> 
> root@mesos002:~/src/mesos/m3/mesos/build# cat /root/test/volume4.json
>   [{
>   "container_path":"\/tmp\/abc1",
>   "mode":"RW",
>   "source":
>     {
>       "docker_volume":
>         {
>           "driver":"convoy",
>           "name":"dvd1"
>         },
>         "type":"DOCKER_VOLUME"
>     }
> },
> {
>   "container_path":"\/tmp\/abc2",
>   "mode":"RW",
>   "source":
>     {
>       "docker_volume":
>         {
>           "driver":"convoy",
>           "driver_options":
>             {"parameter":[
>               {
>                 "key":"iops",
>                 "value":"150"
>               }
>             ]},
>             "name":"dvd2"
>          },
>          "type":"DOCKER_VOLUME"
>     }
> }]
> 
> root@mesos002:~/src/mesos/m3/mesos/build# src/mesos-execute --master=192.168.56.12:5050
--name=test  --command="sleep 1000000" --volumes=/root/test/volume4.json
> I0428 21:27:52.406168  3775 scheduler.cpp:177] Version: 0.29.0
> Subscribed with ID '2a69e042-4e51-4cd9-bcab-e303d6b4b1dd-0003'
> Submitted task 'test' to agent '2a69e042-4e51-4cd9-bcab-e303d6b4b1dd-S0'
> Received status update TASK_RUNNING for task 'test'
>   source: SOURCE_EXECUTOR
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message