mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 45952: Implemented support for passing agent default docker config.
Date Sun, 12 Jun 2016 23:29:48 GMT


> On June 12, 2016, 6:08 p.m., Jie Yu wrote:
> > src/uri/fetchers/docker.cpp, lines 647-649
> > <https://reviews.apache.org/r/45952/diff/4/?file=1415411#file1415411line647>
> >
> >     I don't get this part. This is not what you're doing here, right? I think a
request to authorization server will return an 401 and we will  set auth header and send the
request again. Putting the comments here is confusing. I would simply add a TODO here saying
that here we assume the auth is basic, and we simply include the auth header while sending
the request. It'll be ignored if auth is not required.
> 
> Gilbert Song wrote:
>     Step 3 ~ 7 is what I haven't done here.
>     
>     >> I think a request to authorization server will return an 401 and we will
 set auth header and send the request again.
>     The auth server would always return a token, but the token is incorrect (not accessible)
if no auth attached or the basic auth is incorrect. We could only know that once the wrong
token sent to registry and get an 401. Then we will attach basic auth to request another token
again.
>     
>     Yeah, a little confusing here. Just want to make it in detail, otherwise people may
not understand what this TODO exactly is.
> 
> Gilbert Song wrote:
>     Step 3 ~ 7 is what I haven't done here.
>     
>     >> I think a request to authorization server will return an 401 and we will
set auth header and send the request again.
>     
>     The auth server would always return a token, but the token is incorrect (not accessible)
if no auth attached or the basic auth is incorrect. We could only know that once the wrong
token sent to registry and get an 401. Then we will attach basic auth to request another token
again.
>     
>     >> Putting the comments here is confusing.
>     
>     Yeah, a little confusing here. Just want to make it in detail, otherwise people may
not understand what this TODO exactly is.
> 
> Jie Yu wrote:
>     Regarding using an incorrect toke, are you sure? I want to confirm this. It sounds
unintuitive to me.
> 
> Gilbert Song wrote:
>     Yeah, I remember it behaves this way which also sounds weird to me. Just re-confirmed
by commandline:
>     
>     # no basic auth header attached to authentication server, 401 is from registry because
of incorrect token:
>     ```
>     vagrant@vagrant-ubuntu-trusty-64:~$ curl -s -S -L -D - 'https://auth.docker.io/token?service=registry.docker.io&scope=repository:gilbertsong/inky:pull'
>     HTTP/1.1 200 OK
>     Content-Type: application/json
>     Date: Sun, 12 Jun 2016 19:17:30 GMT
>     Content-Length: 1358
>     Strict-Transport-Security: max-age=31536000
>     
>     {"token":"eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCIsIng1YyI6WyJNSUlDTHpDQ0FkU2dBd0lCQWdJQkFEQUtCZ2dxaGtqT1BRUURBakJHTVVRd1FnWURWUVFERXp0Uk5Gb3pPa2RYTjBrNldGUlFSRHBJVFRSUk9rOVVWRmc2TmtGRlF6cFNUVE5ET2tGU01rTTZUMFkzTnpwQ1ZrVkJPa2xHUlVrNlExazFTekFlRncweE5qQTFNekV5TXpVNE5UZGFGdzB4TnpBMU16RXlNelU0TlRkYU1FWXhSREJDQmdOVkJBTVRPMUV6UzFRNlFqSkpNenBhUjFoT09qSlhXRTA2UTBWWFF6cFVNMHhPT2tvMlYxWTZNbGsyVHpwWlFWbEpPbGhQVTBRNlZFUlJTVG8wVWtwRE1Ga3dFd1lIS29aSXpqMENBUVlJS29aSXpqMERBUWNEUWdBRVo0NkVLV3VKSXhxOThuUC9GWEU3U3VyOXlkZ3c3K2FkcndxeGlxN004VHFUa0N0dzBQZm1SS2VLdExwaXNTRFU4LzZseWZ3QUFwZWh6SHdtWmxZR2dxT0JzakNCcnpBT0JnTlZIUThCQWY4RUJBTUNCNEF3RHdZRFZSMGxCQWd3QmdZRVZSMGxBREJFQmdOVkhRNEVQUVE3VVROTFZEcENNa2t6T2xwSFdFNDZNbGRZVFRwRFJWZERPbFF6VEU0NlNqWlhWam95V1RaUE9sbEJXVWs2V0U5VFJEcFVSRkZKT2pSU1NrTXdSZ1lEVlIwakJEOHdQWUE3VVRSYU16cEhWemRKT2xoVVVFUTZTRTAwVVRwUFZGUllPalpCUlVNNlVrMHpRenBCVWpKRE9rOUdOemM2UWxaRlFUcEpSa1ZKT2tOWk5Vc3dDZ1lJS29aSXpqMEVBd0lEU1FBd1JnSWhBTzYxSWloN1FUcHNTMFFIYUNwTDFZTWNMMnZXZlNydlhHbHpSRDEwN2
 NRUEFpRUFtZXduelNYRHplRGxqcDc4T1NsTFFzbnROYWM5eHRyYW0xU0kxY0ZXQ2tJPSJdfQ.eyJhY2Nlc3MiOltdLCJhdWQiOiJyZWdpc3RyeS5kb2NrZXIuaW8iLCJleHAiOjE0NjU3NTkzNTAsImlhdCI6MTQ2NTc1OTA1MCwiaXNzIjoiYXV0aC5kb2NrZXIuaW8iLCJqdGkiOiJ4MmlfMkxmOEhoUU9IT1VRajV0SiIsIm5iZiI6MTQ2NTc1OTA1MCwic3ViIjoiIn0.WiGorARqU93j6hCXOgXvx_lt9QyCD59oGOLbmbZox1Cqq44rV13hLeqCCtemaWS3gpwtZ12z9exogJNgRRryfA"}
>     
>     vagrant@vagrant-ubuntu-trusty-64:~$ curl -s -S -L -D - -H 'Authorization: Bearer
eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCIsIng1YyI6WyJNSUlDTHpDQ0FkU2dBd0lCQWdJQkFEQUtCZ2dxaGtqT1BRUURBakJHTVVRd1FnWURWUVFERXp0Uk5Gb3pPa2RYTjBrNldGUlFSRHBJVFRSUk9rOVVWRmc2TmtGRlF6cFNUVE5ET2tGU01rTTZUMFkzTnpwQ1ZrVkJPa2xHUlVrNlExazFTekFlRncweE5qQTFNekV5TXpVNE5UZGFGdzB4TnpBMU16RXlNelU0TlRkYU1FWXhSREJDQmdOVkJBTVRPMUV6UzFRNlFqSkpNenBhUjFoT09qSlhXRTA2UTBWWFF6cFVNMHhPT2tvMlYxWTZNbGsyVHpwWlFWbEpPbGhQVTBRNlZFUlJTVG8wVWtwRE1Ga3dFd1lIS29aSXpqMENBUVlJS29aSXpqMERBUWNEUWdBRVo0NkVLV3VKSXhxOThuUC9GWEU3U3VyOXlkZ3c3K2FkcndxeGlxN004VHFUa0N0dzBQZm1SS2VLdExwaXNTRFU4LzZseWZ3QUFwZWh6SHdtWmxZR2dxT0JzakNCcnpBT0JnTlZIUThCQWY4RUJBTUNCNEF3RHdZRFZSMGxCQWd3QmdZRVZSMGxBREJFQmdOVkhRNEVQUVE3VVROTFZEcENNa2t6T2xwSFdFNDZNbGRZVFRwRFJWZERPbFF6VEU0NlNqWlhWam95V1RaUE9sbEJXVWs2V0U5VFJEcFVSRkZKT2pSU1NrTXdSZ1lEVlIwakJEOHdQWUE3VVRSYU16cEhWemRKT2xoVVVFUTZTRTAwVVRwUFZGUllPalpCUlVNNlVrMHpRenBCVWpKRE9rOUdOemM2UWxaRlFUcEpSa1ZKT2tOWk5Vc3dDZ1lJS29aSXpqMEV
 Bd0lEU1FBd1JnSWhBTzYxSWloN1FUcHNTMFFIYUNwTDFZTWNMMnZXZlNydlhHbHpSRDEwN2NRUEFpRUFtZXduelNYRHplRGxqcDc4T1NsTFFzbnROYWM5eHRyYW0xU0kxY0ZXQ2tJPSJdfQ.eyJhY2Nlc3MiOltdLCJhdWQiOiJyZWdpc3RyeS5kb2NrZXIuaW8iLCJleHAiOjE0NjU3NTkzNTAsImlhdCI6MTQ2NTc1OTA1MCwiaXNzIjoiYXV0aC5kb2NrZXIuaW8iLCJqdGkiOiJ4MmlfMkxmOEhoUU9IT1VRajV0SiIsIm5iZiI6MTQ2NTc1OTA1MCwic3ViIjoiIn0.WiGorARqU93j6hCXOgXvx_lt9QyCD59oGOLbmbZox1Cqq44rV13hLeqCCtemaWS3gpwtZ12z9exogJNgRRryfA'
'https://registry-1.docker.io:443/v2/gilbertsong/inky/manifests/latest'
>     HTTP/1.1 401 Unauthorized
>     Content-Type: application/json; charset=utf-8
>     Docker-Distribution-Api-Version: registry/2.0
>     Www-Authenticate: Bearer realm="https://auth.docker.io/token",service="registry.docker.io",scope="repository:gilbertsong/inky:pull",error="insufficient_scope"
>     Date: Sun, 12 Jun 2016 19:18:06 GMT
>     Content-Length: 148
>     Strict-Transport-Security: max-age=31536000
>     
>     {"errors":[{"code":"UNAUTHORIZED","message":"authentication required","detail":[{"Type":"repository","Name":"gilbertsong/inky","Action":"pull"}]}]}
>     ```
>     
>     # with basic auth attached to authentication server:
>     ```
>     vagrant@vagrant-ubuntu-trusty-64:~$ curl -s -S -L -D - -H 'Authorization: Basic Z2lsYmVydHNvbmc6T2ZmZXI4ODg='
'https://auth.docker.io/token?service=registry.docker.io&scope=repository:gilbertsong/inky:pull'
>     HTTP/1.1 200 OK
>     Content-Type: application/json
>     Date: Sun, 12 Jun 2016 19:26:00 GMT
>     Content-Length: 1494
>     Strict-Transport-Security: max-age=31536000
>     
>     {"token":"eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCIsIng1YyI6WyJNSUlDTHpDQ0FkU2dBd0lCQWdJQkFEQUtCZ2dxaGtqT1BRUURBakJHTVVRd1FnWURWUVFERXp0Uk5Gb3pPa2RYTjBrNldGUlFSRHBJVFRSUk9rOVVWRmc2TmtGRlF6cFNUVE5ET2tGU01rTTZUMFkzTnpwQ1ZrVkJPa2xHUlVrNlExazFTekFlRncweE5qQTFNekV5TXpVNE5UZGFGdzB4TnpBMU16RXlNelU0TlRkYU1FWXhSREJDQmdOVkJBTVRPMUV6UzFRNlFqSkpNenBhUjFoT09qSlhXRTA2UTBWWFF6cFVNMHhPT2tvMlYxWTZNbGsyVHpwWlFWbEpPbGhQVTBRNlZFUlJTVG8wVWtwRE1Ga3dFd1lIS29aSXpqMENBUVlJS29aSXpqMERBUWNEUWdBRVo0NkVLV3VKSXhxOThuUC9GWEU3U3VyOXlkZ3c3K2FkcndxeGlxN004VHFUa0N0dzBQZm1SS2VLdExwaXNTRFU4LzZseWZ3QUFwZWh6SHdtWmxZR2dxT0JzakNCcnpBT0JnTlZIUThCQWY4RUJBTUNCNEF3RHdZRFZSMGxCQWd3QmdZRVZSMGxBREJFQmdOVkhRNEVQUVE3VVROTFZEcENNa2t6T2xwSFdFNDZNbGRZVFRwRFJWZERPbFF6VEU0NlNqWlhWam95V1RaUE9sbEJXVWs2V0U5VFJEcFVSRkZKT2pSU1NrTXdSZ1lEVlIwakJEOHdQWUE3VVRSYU16cEhWemRKT2xoVVVFUTZTRTAwVVRwUFZGUllPalpCUlVNNlVrMHpRenBCVWpKRE9rOUdOemM2UWxaRlFUcEpSa1ZKT2tOWk5Vc3dDZ1lJS29aSXpqMEVBd0lEU1FBd1JnSWhBTzYxSWloN1FUcHNTMFFIYUNwTDFZTWNMMnZXZlNydlhHbHpSRDEwN2
 NRUEFpRUFtZXduelNYRHplRGxqcDc4T1NsTFFzbnROYWM5eHRyYW0xU0kxY0ZXQ2tJPSJdfQ.eyJhY2Nlc3MiOlt7InR5cGUiOiJyZXBvc2l0b3J5IiwibmFtZSI6ImdpbGJlcnRzb25nL2lua3kiLCJhY3Rpb25zIjpbInB1bGwiXX1dLCJhdWQiOiJyZWdpc3RyeS5kb2NrZXIuaW8iLCJleHAiOjE0NjU3NTk4NjAsImlhdCI6MTQ2NTc1OTU2MCwiaXNzIjoiYXV0aC5kb2NrZXIuaW8iLCJqdGkiOiJvZUoyc3h3Y2RkdWNvR215RWt6OSIsIm5iZiI6MTQ2NTc1OTU2MCwic3ViIjoiMzdlNTFhNDgtYzkxYy00ZTUzLTg4MTAtYWFkMTNlNmIzYTMwIn0.5LdzM9VitC-sLg-kYMcfb1urHfQLKYLPhTuDIYXFc-fY4VijISVNaDyj9WVTY_ULIT-hCzHiQhp--zIMBtBJiQ"}
>     vagrant@vagrant-ubuntu-trusty-64:~$ curl -s -S -L -D - -H 'Authorization: Bearer
eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCIsIng1YyI6WyJNSUlDTHpDQ0FkU2dBd0lCQWdJQkFEQUtCZ2dxaGtqT1BRUURBakJHTVVRd1FnWURWUVFERXp0Uk5Gb3pPa2RYTjBrNldGUlFSRHBJVFRSUk9rOVVWRmc2TmtGRlF6cFNUVE5ET2tGU01rTTZUMFkzTnpwQ1ZrVkJPa2xHUlVrNlExazFTekFlRncweE5qQTFNekV5TXpVNE5UZGFGdzB4TnpBMU16RXlNelU0TlRkYU1FWXhSREJDQmdOVkJBTVRPMUV6UzFRNlFqSkpNenBhUjFoT09qSlhXRTA2UTBWWFF6cFVNMHhPT2tvMlYxWTZNbGsyVHpwWlFWbEpPbGhQVTBRNlZFUlJTVG8wVWtwRE1Ga3dFd1lIS29aSXpqMENBUVlJS29aSXpqMERBUWNEUWdBRVo0NkVLV3VKSXhxOThuUC9GWEU3U3VyOXlkZ3c3K2FkcndxeGlxN004VHFUa0N0dzBQZm1SS2VLdExwaXNTRFU4LzZseWZ3QUFwZWh6SHdtWmxZR2dxT0JzakNCcnpBT0JnTlZIUThCQWY4RUJBTUNCNEF3RHdZRFZSMGxCQWd3QmdZRVZSMGxBREJFQmdOVkhRNEVQUVE3VVROTFZEcENNa2t6T2xwSFdFNDZNbGRZVFRwRFJWZERPbFF6VEU0NlNqWlhWam95V1RaUE9sbEJXVWs2V0U5VFJEcFVSRkZKT2pSU1NrTXdSZ1lEVlIwakJEOHdQWUE3VVRSYU16cEhWemRKT2xoVVVFUTZTRTAwVVRwUFZGUllPalpCUlVNNlVrMHpRenBCVWpKRE9rOUdOemM2UWxaRlFUcEpSa1ZKT2tOWk5Vc3dDZ1lJS29aSXpqMEV
 Bd0lEU1FBd1JnSWhBTzYxSWloN1FUcHNTMFFIYUNwTDFZTWNMMnZXZlNydlhHbHpSRDEwN2NRUEFpRUFtZXduelNYRHplRGxqcDc4T1NsTFFzbnROYWM5eHRyYW0xU0kxY0ZXQ2tJPSJdfQ.eyJhY2Nlc3MiOlt7InR5cGUiOiJyZXBvc2l0b3J5IiwibmFtZSI6ImdpbGJlcnRzb25nL2lua3kiLCJhY3Rpb25zIjpbInB1bGwiXX1dLCJhdWQiOiJyZWdpc3RyeS5kb2NrZXIuaW8iLCJleHAiOjE0NjU3NTk4NjAsImlhdCI6MTQ2NTc1OTU2MCwiaXNzIjoiYXV0aC5kb2NrZXIuaW8iLCJqdGkiOiJvZUoyc3h3Y2RkdWNvR215RWt6OSIsIm5iZiI6MTQ2NTc1OTU2MCwic3ViIjoiMzdlNTFhNDgtYzkxYy00ZTUzLTg4MTAtYWFkMTNlNmIzYTMwIn0.5LdzM9VitC-sLg-kYMcfb1urHfQLKYLPhTuDIYXFc-fY4VijISVNaDyj9WVTY_ULIT-hCzHiQhp--zIMBtBJiQ'
'https://registry-1.docker.io:443/v2/gilbertsong/inky/manifests/latest'
>     HTTP/1.1 200 OK
>     Content-Length: 5005
>     Content-Type: application/vnd.docker.distribution.manifest.v1+prettyjws
>     Docker-Content-Digest: sha256:0d06959e9b1f54e7f959935439423aa2f1299c802eec2952e709ffb551fbf0d4
>     Docker-Distribution-Api-Version: registry/2.0
>     Etag: "sha256:0d06959e9b1f54e7f959935439423aa2f1299c802eec2952e709ffb551fbf0d4"
>     Date: Sun, 12 Jun 2016 19:26:29 GMT
>     Strict-Transport-Security: max-age=31536000
>     
>     {
>        "schemaVersion": 1,
>        "name": "gilbertsong/inky",
>        "tag": "latest",
>        "architecture": "amd64",
>        "fsLayers": [
>           {
>              "blobSum": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4"
>           },
>           {
>              "blobSum": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4"
>           },
>           {
>              "blobSum": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4"
>           },
>           {
>              "blobSum": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4"
>           },
>           {
>              "blobSum": "sha256:1db09adb5ddd7f1a07b6d585a7db747a51c7bd17418d47e91f901bdf420abd66"
>           },
>           {
>              "blobSum": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4"
>           },
>           {
>              "blobSum": "sha256:a3ed95caeb02ffe68cdd9fd84406680ae93d633cb16422d00e8a7c22955b46d4"
>           }
>        ],
>        "history": [
>           {
>              "v1Compatibility": "{\"architecture\":\"amd64\",\"author\":\"support@mesosphere.io\",\"config\":{\"Hostname\":\"f7d939e68b5a\",\"Domainname\":\"\",\"User\":\"\",\"AttachStdin\":false,\"AttachStdout\":false,\"AttachStderr\":false,\"Tty\":false,\"OpenStdin\":false,\"StdinOnce\":false,\"Env\":[\"HOME=/\",\"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\"],\"Cmd\":[\"inky\"],\"Image\":\"be4ce2753831b8952a5b797cf45b2230e1befead6f5db0630bcb24a5f554255e\",\"Volumes\":null,\"WorkingDir\":\"\",\"Entrypoint\":[\"echo\"],\"OnBuild\":[],\"Labels\":null},\"container\":\"5d55401ff99c7508c9d546926b711c78e3ccb36e39a848024b623b2aef4c2c06\",\"container_config\":{\"Hostname\":\"f7d939e68b5a\",\"Domainname\":\"\",\"User\":\"\",\"AttachStdin\":false,\"AttachStdout\":false,\"AttachStderr\":false,\"Tty\":false,\"OpenStdin\":false,\"StdinOnce\":false,\"Env\":[\"HOME=/\",\"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\"],\"Cmd\":[\"/bin/sh\",\"-c\",\"#(no
 p) ENTRYPOINT [echo]\"],\"Image\":\"be4ce2753831b8952a5b797cf45b2230e1befead6f5db0630bcb24a5f554255e\",\"Volumes\":null,\"WorkingDir\":\"\",\"Entrypoint\":[\"echo\"],\"OnBuild\":[],\"Labels\":null},\"created\":\"2014-08-15T00:31:36.407713553Z\",\"docker_version\":\"1.1.2\",\"id\":\"3603417caa0c104e00188af9913284fac2fb7766b592d5b86e23f17112521e59\",\"os\":\"linux\",\"parent\":\"cba51fbb813a90e6ee0d1be96b2d9bdb7bddca9b1d3a859854b7e1ef20efc60a\"}"
>           },
>           {
>              "v1Compatibility": "{\"id\":\"cba51fbb813a90e6ee0d1be96b2d9bdb7bddca9b1d3a859854b7e1ef20efc60a\",\"parent\":\"d79db9b54cefc5f7b99bfcdd6518a218b5bdb5740aab60023e53f47331c6f607\",\"created\":\"2014-08-15T00:31:36.247988044Z\",\"container_config\":{\"Cmd\":[\"/bin/sh
-c #(nop) CMD [inky]\"]}}"
>           },
>           {
>              "v1Compatibility": "{\"id\":\"d79db9b54cefc5f7b99bfcdd6518a218b5bdb5740aab60023e53f47331c6f607\",\"parent\":\"9ff89670cd9bf085a8e1f07324b590212c7c7563fa4c53d31185d5e7a2259cdf\",\"created\":\"2014-08-15T00:31:36.068514721Z\",\"container_config\":{\"Cmd\":[\"/bin/sh
-c #(nop) MAINTAINER support@mesosphere.io\"]}}"
>           },
>           {
>              "v1Compatibility": "{\"id\":\"9ff89670cd9bf085a8e1f07324b590212c7c7563fa4c53d31185d5e7a2259cdf\",\"parent\":\"843388cfa44740d5d602a1d87eb44857bdf6549ab39ac5c40c5918ab53003972\",\"created\":\"2014-06-05T00:05:35.990887725Z\",\"container_config\":{\"Cmd\":[\"/bin/sh
-c #(nop) CMD [/bin/sh]\"]}}"
>           },
>           {
>              "v1Compatibility": "{\"id\":\"843388cfa44740d5d602a1d87eb44857bdf6549ab39ac5c40c5918ab53003972\",\"parent\":\"8e9880e2f2f433621c34c94d346eecaf8e8e500e3e55f52a6c322d2f747ae137\",\"created\":\"2014-06-05T00:05:35.692528634Z\",\"container_config\":{\"Cmd\":[\"/bin/sh
-c #(nop) ADD file:88f36b32456f849299e5df807a1e3514cf1da798af9692a0004598e500be5901 in /\"]}}"
>           },
>           {
>              "v1Compatibility": "{\"id\":\"8e9880e2f2f433621c34c94d346eecaf8e8e500e3e55f52a6c322d2f747ae137\",\"parent\":\"3690474eb5b4b26fdfbd89c6e159e8cc376ca76ef48032a30fa6aafd56337880\",\"created\":\"2014-06-05T00:05:35.589531476Z\",\"container_config\":{\"Cmd\":[\"/bin/sh
-c #(nop) MAINTAINER Jérôme Petazzoni \u003cjerome@docker.com\u003e\"]}}"
>           },
>           {
>              "v1Compatibility": "{\"id\":\"3690474eb5b4b26fdfbd89c6e159e8cc376ca76ef48032a30fa6aafd56337880\",\"comment\":\"Imported
from -\",\"created\":\"2013-06-13T14:03:50.821769-07:00\",\"container_config\":{\"Cmd\":[\"\"]}}"
>           }
>        ],
>        "signatures": [
>           {
>              "header": {
>                 "jwk": {
>                    "crv": "P-256",
>                    "kid": "UJES:UK4E:N5CS:VC2X:CUK5:J5N7:VHNB:3OBT:6QAO:U6ZP:NE5N:VPJT",
>                    "kty": "EC",
>                    "x": "IRpiU6PNf3BE5RBQBOiWPl8FX-fWF6p8LoEeOn-8OMA",
>                    "y": "wlbSpkSzJVojYQUfWmQbDDM3T2_IqfgWIV51HXl2tcA"
>                 },
>                 "alg": "ES256"
>              },
>              "signature": "iljLktRF8UWlk-_y-E_Kk0fzqkrjRZmqzSHr2WgiFuQi1C1xVDSyb9bPxvWbU7Fs86K5KCUXlie6ONGrVBzJJA",
>              "protected": "eyJmb3JtYXRMZW5ndGgiOjQzNTgsImZvcm1hdFRhaWwiOiJDbjAiLCJ0aW1lIjoiMjAxNi0wNi0xMlQxOToyNjoyOVoifQ"
>           }
>        ]
>     ```

Cool, thanks for confirming it!


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45952/#review137183
-----------------------------------------------------------


On June 12, 2016, 7:11 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45952/
> -----------------------------------------------------------
> 
> (Updated June 12, 2016, 7:11 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4938
>     https://issues.apache.org/jira/browse/MESOS-4938
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented support for passing agent default docker config.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp cd5849bb9cdd12f2240885a0eae90569d2a9502e

>   src/uri/fetchers/docker.hpp c855a2b55a07bb398f7547b44a85b8ba2d2b2ec3 
>   src/uri/fetchers/docker.cpp ab8f5e05758b7de2573605c81ac80e656bb1db24 
> 
> Diff: https://reviews.apache.org/r/45952/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Tested with mesos-execute, using a private repo from docker hub. Both cases are tested:
> 1. --docker_registry=private_registry
> 2. private_registry/repo
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message