mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <>
Subject Re: Review Request 48364: Removed hard dependence on `` for Nvidia GPU support.
Date Sat, 11 Jun 2016 03:16:26 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 11, 2016, 3:16 a.m.)

Review request for mesos and Benjamin Mahler.


Updated name of library to `dlopen()` from -->
Updated name of symbol to load using `dlsym()` from `"nvmlInit"` to `"nvmlInit_v2"`.

These changes were made after an external review of the code made by Nividia.

Bugs: MESOS-5550

Repository: mesos


We now use a singleton class called `NvidiaManagementLibrary` that
loads `libnvidia-ml` at runtime once it is initialized. By loading
this library dynamically, `libmesos` no longer has a hard dependence
on it, so it doesn't have to be installed on every machine where mesos
is deployed.

This was a problem previously, whereby the master and agents that
didn't even have GPUs would unnecessarily need to have `libnvidia-ml`
installed on their systems. This library is not easily installable
(it's not bundled in standard apt-get or yum repositories), so this
was a major inconvenience.

Diffs (updated)
----- e344c56e1be5e232ee331c933b8c04c4c2e55d1e 
  src/ b656702d918e747cbd4b3d8f2c4257f61c83b385 
  src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp 181a2aad97da9ee0f6ffa42cdba9c93dc0077ff7

  src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp d7557a0c338e8c0e51461b2326600c03f89c2e8b

  src/slave/containerizer/mesos/isolators/gpu/nvml.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/gpu/nvml.cpp PRE-CREATION 



GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Kevin Klues

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message