mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 48366: Added auto-discovery of GPUs for Nvidia GPU support.
Date Sat, 11 Jun 2016 03:07:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48366/
-----------------------------------------------------------

(Updated June 11, 2016, 3:07 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Rebased for https://reviews.apache.org/r/48578


Bugs: MESOS-5257
    https://issues.apache.org/jira/browse/MESOS-5257


Repository: mesos


Description
-------

This commit also includes updates to the tests that would start
failing once GPU autodiscovery was turned on. Since GPUs are now a
first class resource, we have to explicilty list them in resource
vectors that attempt to set resources for the whole machine and then
verify that they get the same vector back in an offer.


Diffs (updated)
-----

  src/slave/containerizer/containerizer.cpp faa0c789dda8a6f36fdb6217b0bae270b6b8f2e2 
  src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp d7557a0c338e8c0e51461b2326600c03f89c2e8b

  src/tests/master_allocator_tests.cpp 34e3add78d0dec8fb55d7b35710694bea3c58d6f 
  src/tests/master_quota_tests.cpp 62aaafe7b11a7df1ca7bc1f2f29af4cb626fc35d 
  src/tests/master_tests.cpp 0d64e353f0682017953b524a5f5246d76f52fa2e 
  src/tests/mesos.hpp e9361a65eb31cced99e9ed32fd18a65d1bda26e3 
  src/tests/persistent_volume_endpoints_tests.cpp 70b7626c8e87d1de59b13f9fd88fe9abb5f6b6a5

  src/tests/slave_tests.cpp 7ba03e8c06b8aaac1e57124c257660acd8c1d78a 

Diff: https://reviews.apache.org/r/48366/diff/


Testing
-------

GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message