mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 48368: Changed major/minor device types for Nvidia GPUs to `unsigned int`.
Date Sat, 11 Jun 2016 03:06:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48368/
-----------------------------------------------------------

(Updated June 11, 2016, 3:06 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Rebased for https://reviews.apache.org/r/48578


Bugs: MESOS-5554
    https://issues.apache.org/jira/browse/MESOS-5554


Repository: mesos


Description
-------

Previously, the GPU struct specified the type of its `major` and
`minor` fields as `dev_t`, which is actually a concatenation of both
the major and minor device numbers accessible through the `major()`
and `minor()` macros. These macros return an `unsigned int` when
handed a `dev_t`, so it makes sense for these fields to be of that
type instead.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp 181a2aad97da9ee0f6ffa42cdba9c93dc0077ff7

  src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp d7557a0c338e8c0e51461b2326600c03f89c2e8b


Diff: https://reviews.apache.org/r/48368/diff/


Testing
-------

GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message