mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 48370: Fixed method of populating device entries for `/dev/nvidia-uvm`, etc.
Date Sat, 11 Jun 2016 03:06:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48370/
-----------------------------------------------------------

(Updated June 11, 2016, 3:06 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Rebased for https://reviews.apache.org/r/48578


Bugs: MESOS-5556
    https://issues.apache.org/jira/browse/MESOS-5556


Repository: mesos


Description
-------

Previously, the major/minor numbers of `/dev/nvidiactl` and
`/dev/nvidia-uvm` were hard-coded. This actually caused problems for
`/dev/nvidia-uvm` because its major number is part of the
"Experimental" device range on Linux.

Because this range is experimental, there is no guarantee which device
number will be assigned to it on a given machine. We actually
encountered this problem in the wild, prompting this change.

We now use `os:stat::rdev()` to extract the major/minor numbers
programatically.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp 181a2aad97da9ee0f6ffa42cdba9c93dc0077ff7

  src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp d7557a0c338e8c0e51461b2326600c03f89c2e8b


Diff: https://reviews.apache.org/r/48370/diff/


Testing
-------

GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message