mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 48374: Added class to share Nvidia-specific components between containerizers.
Date Sat, 11 Jun 2016 03:05:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48374/
-----------------------------------------------------------

(Updated June 11, 2016, 3:05 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Rebased for https://reviews.apache.org/r/48578


Bugs: MESOS-5562
    https://issues.apache.org/jira/browse/MESOS-5562


Repository: mesos


Description
-------

Previously, the `NvidiaGpuAllocator` component was created directly
inside the `NvidiaGpuIsolatorProcess` even though it was designed to
be used by multiple containerizers at the same time. To allow for
simultaneous access, we created a new `NvidiaComponents` class to hold
a reference to a shared `NvidiaGpuAllocator` instance and pass it to
each containerizer as it is created. This component can easily be
extended to include more cross-containerizer components later on.

We create the `NvidiaComponents` instance inside
`Containerizer::create()` and pass it to both the docker containerizer
and the mesos containerizer when they are created.  The docker
containerizer currently doesn't do anything with this information, but
its interface has been updated to accomodate it. The mesos
containerizer has been updated to pass this all the way down to the
`NvidiaGpuIsolatorProcess` and exploit it.


Diffs (updated)
-----

  src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 
  src/slave/containerizer/containerizer.cpp faa0c789dda8a6f36fdb6217b0bae270b6b8f2e2 
  src/slave/containerizer/docker.hpp 311dca23ac17fb533866aba1de2b81d750bbe6df 
  src/slave/containerizer/docker.cpp 1af5b451922e1eeb0af025f29c53a85ab9deec3b 
  src/slave/containerizer/mesos/containerizer.hpp a1a00020668f6da8d611f26e5637afffc87d09ba

  src/slave/containerizer/mesos/containerizer.cpp 92c9898fb41ca0ffbda05e53b595b05c96f4f596

  src/slave/containerizer/mesos/isolators/gpu/components.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp 181a2aad97da9ee0f6ffa42cdba9c93dc0077ff7

  src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp d7557a0c338e8c0e51461b2326600c03f89c2e8b


Diff: https://reviews.apache.org/r/48374/diff/


Testing
-------

GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message