mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 48371: Added `NvidiaGpuAllocator` component.
Date Sat, 11 Jun 2016 03:04:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48371/
-----------------------------------------------------------

(Updated June 11, 2016, 3:04 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Rebased for https://reviews.apache.org/r/48578


Bugs: MESOS-5557
    https://issues.apache.org/jira/browse/MESOS-5557


Repository: mesos


Description
-------

This component is designed to serve as a centralized component for
allocating / deallocating Nvidia GPUs. The goal is to share an
instance of this across both the mesos containerizer and the docker
containerizer so they can allocate GPUs from the same shared pool.

It is overloaded to also do resource enumeration of GPUs based on
the agent flags. This keeps all code for enumerating GPUs and the
resources they represent in a single centralized location.


Diffs (updated)
-----

  src/Makefile.am b656702d918e747cbd4b3d8f2c4257f61c83b385 
  src/slave/containerizer/mesos/isolators/gpu/allocator.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/gpu/allocator.cpp PRE-CREATION 
  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 65ffbafffeb5dac372b5770d2a1560a942a822e2


Diff: https://reviews.apache.org/r/48371/diff/


Testing
-------

GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message