mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 47374: Separated mesos test helpers into a separate library.
Date Sat, 11 Jun 2016 00:03:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47374/
-----------------------------------------------------------

(Updated June 10, 2016, 5:03 p.m.)


Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, Kapil Arya, Jan Schlicht, and
Till Toenshoff.


Changes
-------

Removed "experiment" label after some builds + writing module tests in a separate repository.
Updated description with some insights gained from the above.


Summary (updated)
-----------------

Separated mesos test helpers into a separate library.


Repository: mesos


Description (updated)
-------

This gives external projects easier access to the test helpers used in
mesos tests.  

For example, a module writer may want to write a test like 
`src/tests/oversubscription_tests.cpp`.  To build and link against 
this library, the module writer would mimic the build flags for tests:
```
# Main test file is taken directly from Mesos.
my_module_tests_SOURCES = \
  $(MESOS)/src/tests/main.cpp

my_module_tests_CPPFLAGS = \
  -I$(GMOCK)/include       \
  -I$(GTEST)/include       \
  -I$(MESOS)/include/mesos \
  -I$(ZOOKEEPER)/include   \
  -I$(ZOOKEEPER)/generated \
  $(AM_CPPFLAGS)
  
my_module_tests_LDADD = \
  $(MESOS)/3rdparty/.libs/libgmock.la \
  $(MESOS)/src/.libs/libmesos.la      \
  $(MESOS)/src/.libs/libmesos_tests.la
```


Diffs
-----

  src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 

Diff: https://reviews.apache.org/r/47374/diff/


Testing (updated)
-------

make check on OSX, CentOS 7, Ubuntu 14


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message