mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.
Date Fri, 10 Jun 2016 23:43:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47667/#review137083
-----------------------------------------------------------




3rdparty/stout/include/stout/os/posix/su.hpp (line 177)
<https://reviews.apache.org/r/47667/#comment202233>

    Do you need to follow the same to get maxgroups here?



3rdparty/stout/include/stout/os/posix/su.hpp (lines 187 - 189)
<https://reviews.apache.org/r/47667/#comment202234>

    You can do `return std::vector<gid_t>(gids, gids + ngroups);



3rdparty/stout/include/stout/os/posix/su.hpp (lines 205 - 209)
<https://reviews.apache.org/r/47667/#comment202245>

    I would say that we cannot simply call 'setgroups' here because it only updates the in
kernel cache, but not the ones in opendirectoryd. Darwin kernel caches part of the groups
in kernel, and the rest in opendirectoryd.



3rdparty/stout/include/stout/os/posix/su.hpp (line 217)
<https://reviews.apache.org/r/47667/#comment202243>

    indentation


- Jie Yu


On May 26, 2016, 8:55 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47667/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 8:55 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, and Timothy
Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added stout functions to get and set supplementary groud ids.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/posix/su.hpp 43e91d6baca9b5e0bb7d6661c4d8002b07d22452

> 
> Diff: https://reviews.apache.org/r/47667/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message