mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.
Date Fri, 10 Jun 2016 17:59:58 GMT


> On June 9, 2016, 10:56 p.m., Vinod Kone wrote:
> > No tests for this and the previous review?

Hi, @vinodkone. `START_MAINTENANCE` and `STOP_MAINTENANCE` are still in progress because I
have some remain problems about api_tests.cpp as discussions in [48259](https://reviews.apache.org/r/48259/)
and [48260](https://reviews.apache.org/r/48260/).
I would post the test cases with below patches fixes as well. :)


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48286/#review136923
-----------------------------------------------------------


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48286/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5507
>     https://issues.apache.org/jira/browse/MESOS-5507
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented STOP_MAINTENANCE Call in v1 master API.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48286/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message