mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhang...@cn.ibm.com>
Subject Re: Review Request 46158: Completed implementation of the cgroups unified isolator.
Date Fri, 10 Jun 2016 14:28:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46158/#review136985
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 76 - 78)
<https://reviews.apache.org/r/46158/#comment202099>

    I think these 3 lines can be merged into 1 line which will not exceed 80 chars.



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 368 - 370)
<https://reviews.apache.org/r/46158/#comment202107>

    If we return from here, then I think we will not have chance to destroy the cgroups that
we created for this container in `prepareHierarchy()`. The reason is, here we have not put
`info` into `infos`, so in `CgroupsIsolatorProcess::cleanup()`, we will not do anything for
this container since `infos` does not contains its `info`.
    So I would suggest to do `infos[containerId] = info;` right after we get a newly created
`info` from `info::create()`


- Qian Zhang


On April 16, 2016, 6:14 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46158/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-5041
>     https://issues.apache.org/jira/browse/MESOS-5041
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Completed implementation of the cgroups unified isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46158/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message