mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guangya Liu <gyliu...@gmail.com>
Subject Re: Review Request 48455: Removed unused import from sorter.cpp.
Date Fri, 10 Jun 2016 00:51:41 GMT


> On 六月 9, 2016, 9:18 p.m., Benjamin Mahler wrote:
> > src/master/allocator/sorter/drf/sorter.cpp, lines 17-18
> > <https://reviews.apache.org/r/48455/diff/1/?file=1411814#file1411814line17>
> >
> >     Rather than just removing this one, would you mind doing an audit of the headers?
We're missing a lot of includes here.

@Ben, how did you fix this? Seems the commit message below does not align with this patch.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48455/#review136896
-----------------------------------------------------------


On 六月 9, 2016, 1:30 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48455/
> -----------------------------------------------------------
> 
> (Updated 六月 9, 2016, 1:30 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unused import from sorter.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/sorter/drf/sorter.cpp 65d473a5da0d846214c930c14d333040b2085b13

> 
> Diff: https://reviews.apache.org/r/48455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message