mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 45960: Added interfaces to handle and track shareable resources.
Date Fri, 10 Jun 2016 00:48:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45960/#review136944
-----------------------------------------------------------


Fix it, then Ship it!





src/common/resources.cpp (line 756)
<https://reviews.apache.org/r/45960/#comment202053>

    Two space indentation.



src/common/resources.cpp (line 760)
<https://reviews.apache.org/r/45960/#comment202054>

    Two space indentation.



src/v1/resources.cpp (line 759)
<https://reviews.apache.org/r/45960/#comment202055>

    Two space indentation.



src/v1/resources.cpp (line 763)
<https://reviews.apache.org/r/45960/#comment202056>

    Two space indentation.


- Jiang Yan Xu


On May 22, 2016, 12:09 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45960/
> -----------------------------------------------------------
> 
> (Updated May 22, 2016, 12:09 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-4431
>     https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added interfaces to handle and track shareable resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp a557e97c65194d4aad879fb88d8edefd1c95b8d8 
>   include/mesos/v1/resources.hpp a5ba8fec4c9c3643646308f75a4b28cefe0b3df3 
>   src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 
>   src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a 
> 
> Diff: https://reviews.apache.org/r/45960/diff/
> 
> 
> Testing
> -------
> 
> Tests successful.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message