mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 45905: Added metrics to the balloon framework.
Date Thu, 09 Jun 2016 23:55:11 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 9, 2016, 4:55 p.m.)

Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.


Renamed `allowed_terminations` to `launch_failures`.  Also touched up a related comment.

Bugs: MESOS-5174

Repository: mesos


Adds metrics to gauge the health of the framework.  This includes:

* uptime_secs = How long the framework has been running.
* registered = If the framework is registered.
* tasks_finished = Number of tasks finished (successfully).
* tasks_oomed = Number of tasks that were OOM killed.
* allowed_terminations = Number of terminal status updates which
  are acceptable due to infrastructure reasons.
* abnormal_terminations = Number of terminal status updates which 
  were not `TASK_FINISHED` or `TASK_FAILED` due to OOM.

Diffs (updated)

  src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 



make check

sudo bin/ --gtest_filter="*ROOT_CGROUPS_BalloonFramework"

# Also launched two instances on a cluster.
# This one OOM's:
./balloon-framework --master=zk://localhost:2181/mesos --checkpoint --balloon_limit=256MB
--task_memory=128MB --executor_uri="" --executor_command="LD_LIBRARY_PATH=/path/to/libmesos
&& ./balloon-executor"

# This one does not OOM:
./balloon-framework --master=zk://localhost:2181/mesos --checkpoint --balloon_limit=256MB
--task_memory=256MB --executor_uri="" --executor_command="LD_LIBRARY_PATH=/path/to/libmesos
&& ./balloon-executor"


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message