mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 48303: Split the balloon scheduler into a Process to support metrics.
Date Thu, 09 Jun 2016 23:53:56 GMT


> On June 7, 2016, 2:23 p.m., Vinod Kone wrote:
> > src/examples/balloon_framework.cpp, line 255
> > <https://reviews.apache.org/r/48303/diff/1/?file=1407808#file1407808line255>
> >
> >     why this change?

Ah, that line should have been in the next commit.  I made a mistake while splitting the commit.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48303/#review136546
-----------------------------------------------------------


On June 9, 2016, 4:53 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48303/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5174
>     https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a `BalloonSchedulerProcess` which holds a subset of the `Scheduler`
> class's methods.  The `BalloonScheduler` dispatches to the process
> when for non-logging business logic.  This also opens up the balloon 
> framework for libprocess metrics.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 
> 
> Diff: https://reviews.apache.org/r/48303/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message