mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 46407: Updated balloon executor.
Date Thu, 09 Jun 2016 23:09:35 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 9, 2016, 4:09 p.m.)

Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.


Comment tweak + move TASK_RUNNING status update into the thread.

Bugs: MESOS-5174

Repository: mesos


Fixes the logic in the example `balloon-executor` to work in cases not
exercised by the `ROOT_CGROUPS_BalloonFramework` test.

* The "task" logic was moved into a separate thread.  This fixes the 
  case where the balloon executor does not exceed the memory limit.
  (i.e. by Unblocking the driver's thread while sending status updates.)
* Changed log messages to use glog.
* Added logic to prevent multiple task launches with the same executor.

Diffs (updated)

  src/examples/balloon_executor.cpp 2a79c353e96930d25495732d15b83c82247974bb 



See next review in this chain.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message