mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.
Date Thu, 09 Jun 2016 22:51:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48259/#review136912
-----------------------------------------------------------




src/tests/api_tests.cpp (line 73)
<https://reviews.apache.org/r/48259/#comment202017>

    make this private? 
    
    also move this below public functions.



src/tests/api_tests.cpp (line 113)
<https://reviews.apache.org/r/48259/#comment202022>

    this returns `Nothing` and not `Accepted`.
    
    I actually think this helper is a bit confusing than useful. Just calling http::post()
directly in the tests that don't expect a v1::Response is probably better?



src/tests/api_tests.cpp (line 261)
<https://reviews.apache.org/r/48259/#comment202024>

    s/schedule/v1Schedule/



src/tests/api_tests.cpp (lines 264 - 268)
<https://reviews.apache.org/r/48259/#comment202025>

    lets just have an evolve function that evolves unversioned schedule to v1::maintenance::schedule?



src/tests/api_tests.cpp (lines 295 - 299)
<https://reviews.apache.org/r/48259/#comment202027>

    lets have and use devolve() here.


- Vinod Kone


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48259/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5504
>     https://issues.apache.org/jira/browse/MESOS-5504
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48259/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message