mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <mazumdar.an...@gmail.com>
Subject Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.
Date Thu, 09 Jun 2016 21:45:52 GMT


> On June 9, 2016, 9:14 p.m., Joseph Wu wrote:
> > src/master/http.cpp, lines 3286-3289
> > <https://reviews.apache.org/r/48084/diff/4/?file=1412873#file1412873line3286>
> >
> >     I probably missed a discussion elsewhere...
> >     
> >     Aren't all (master) operator API's supposed to return `v1::master::Response`?

We recently changed them. Here is the dev@ discussion thread: https://mail-archives.apache.org/mod_mbox/mesos-dev/201606.mbox/%3CCAFt%3DROPU%2B22%3D0JUnuWcSFdc3KU_5i5n44DJa_v1pr6QwTyfqxA%40mail.gmail.com%3E


- Anand


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48084/#review136895
-----------------------------------------------------------


On June 9, 2016, 5:49 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48084/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 5:49 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Vinod Kone.
> 
> 
> Bugs: MESOS-5503
>     https://issues.apache.org/jira/browse/MESOS-5503
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented v1::master::Call::GET_MAINTENANCE_STATUS.
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b 
>   src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c 
>   src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb 
> 
> Diff: https://reviews.apache.org/r/48084/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message