mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48450: Add unit test for master /tasks endpoint.
Date Thu, 09 Jun 2016 21:27:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48450/#review136898
-----------------------------------------------------------




src/tests/master_tests.cpp (lines 2495 - 2518)
<https://reviews.apache.org/r/48450/#comment202008>

    same comments apply as in the previous review.



src/tests/master_tests.cpp (line 2558)
<https://reviews.apache.org/r/48450/#comment202009>

    this is awesome. thanks for going the extra mile to write this test!!


- Vinod Kone


On June 9, 2016, midnight, Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48450/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, midnight)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add unit test for master /tasks endpoint.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 34be015aa314a7574e9065efb7b1bb8e1570c5b7 
> 
> Diff: https://reviews.apache.org/r/48450/diff/
> 
> 
> Testing
> -------
> 
> make check on Ubuntu 14.04 & OSX
> 
> I didn't find unit test for this endpoint, therefore adding it.
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message