mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.
Date Thu, 09 Jun 2016 21:26:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48046/#review136822
-----------------------------------------------------------




src/master/http.cpp (line 645)
<https://reviews.apache.org/r/48046/#comment201905>

    you want to rebase this on top of haosdent's recent changes that I committed.



src/master/http.cpp (lines 1412 - 1415)
<https://reviews.apache.org/r/48046/#comment201906>

    uncomment this after you rebase because `getTasks` will return http::Response() now.



src/tests/api_tests.cpp (line 164)
<https://reviews.apache.org/r/48046/#comment201907>

    s/presents/is present/



src/tests/api_tests.cpp (line 171)
<https://reviews.apache.org/r/48046/#comment201908>

    What does this comment mean? I didn't follow.
    
    Also, comments should start with a capital letter and end in a period.



src/tests/api_tests.cpp (line 217)
<https://reviews.apache.org/r/48046/#comment202005>

    give it a name, say "test"



src/tests/api_tests.cpp (lines 229 - 233)
<https://reviews.apache.org/r/48046/#comment202006>

    do we really need this expectation? i think scheduler receiving the update should be enough
to gurantee that master has already updated the state of the task?



src/tests/api_tests.cpp (line 246)
<https://reviews.apache.org/r/48046/#comment202007>

    see above. kill this?



src/tests/api_tests.cpp (line 249)
<https://reviews.apache.org/r/48046/#comment202003>

    ditto. see above.



src/tests/api_tests.cpp (line 262)
<https://reviews.apache.org/r/48046/#comment202004>

    align this with first argument.
    
    ```
    ASSERT_EQ(arg1,
              arg2);
    ```


- Vinod Kone


On June 9, 2016, 12:49 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48046/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-5493
>     https://issues.apache.org/jira/browse/MESOS-5493
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implement v1::master::Call::GET_TASKS.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840 
>   src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 
>   src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48046/diff/
> 
> 
> Testing
> -------
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message