mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48455: Removed unused import from sorter.cpp.
Date Thu, 09 Jun 2016 21:18:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48455/#review136896
-----------------------------------------------------------




src/master/allocator/sorter/drf/sorter.cpp 
<https://reviews.apache.org/r/48455/#comment202002>

    Rather than just removing this one, would you mind doing an audit of the headers? We're
missing a lot of includes here.


- Benjamin Mahler


On June 9, 2016, 1:30 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48455/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 1:30 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unused import from sorter.cpp.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/sorter/drf/sorter.cpp 65d473a5da0d846214c930c14d333040b2085b13

> 
> Diff: https://reviews.apache.org/r/48455/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message