mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 48478: Created a `cgroups/devices` isolator.
Date Thu, 09 Jun 2016 21:12:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48478/#review136894
-----------------------------------------------------------


Ship it!




Looks good, I made some minor tweaks and added the new files to the cmake build.

We should have some tests for this new isolator, I'll leave MESOS-5582 open for the addition
of the tests.

- Benjamin Mahler


On June 9, 2016, 7:34 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48478/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 7:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-5582
>     https://issues.apache.org/jira/browse/MESOS-5582
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, all the logic for the `cgroups/devices` isolator was
> bundled into the Nvidia GPU Isolator. Now we have abstracted it out
> into it's own component and removed the redundant logic from the
> Nvidia GPU Isolator. Because of the new guaranteed ordering between
> isolators, we can be sure that the dependency order between the
> `cgroups/devices` and `gpu/nvidia` isolators is met.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 29525c960e8fb2448260efdd774fd8fc1d68047b 
>   src/slave/containerizer/mesos/containerizer.cpp c7b9744463cf8e1921dcb5e2b7dec7d4e2c0e45f

>   src/slave/containerizer/mesos/isolators/cgroups/devices.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/devices.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.hpp f290e3c1d1114698039a505e972793dc325c7100

>   src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp 7849e518af448d9557ca4d6de4ccaba8bc572992

>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp b1e64b2fc5518463cd14e119f89e3cd298286052

> 
> Diff: https://reviews.apache.org/r/48478/diff/
> 
> 
> Testing
> -------
> 
> make -j check
> GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message