mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 47664: Implemented image user support in docker runtime isolator.
Date Thu, 09 Jun 2016 20:51:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47664/#review136889
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/runtime.cpp (line 101)
<https://reviews.apache.org/r/47664/#comment201996>

    I suggest we return a Failure if container user is specified since we don't support it
right now.


- Jie Yu


On May 26, 2016, 8:55 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47664/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 8:55 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, and Timothy
Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented image user support in docker runtime isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.hpp 272636fcf12c865b31a11364f23d7aee9c6225db

>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp eb2790d44ee08c81d31fbe28e7a8ffe88edba870

> 
> Diff: https://reviews.apache.org/r/47664/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message