mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 47663: Added image user to 'ContainerLaunchInfo'.
Date Thu, 09 Jun 2016 19:30:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47663/#review136880
-----------------------------------------------------------




include/mesos/slave/isolator.proto (line 133)
<https://reviews.apache.org/r/47663/#comment201983>

    See my comment in the following patch. Let's do:
    ```
    // The user name or UID in the container.
    optional string user = 7;
    
    // The group name or GID in the container.
    optional string group = 8;
    
    // TODO: Add repeated supplementary groups.
    ```
    
    No need 'image' prefix because it's pretty clear this is for the container.


- Jie Yu


On May 26, 2016, 8:55 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47663/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 8:55 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin Klues, and Timothy
Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added image user to 'ContainerLaunchInfo'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 
> 
> Diff: https://reviews.apache.org/r/47663/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message