mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bing Li <bingli1...@gmail.com>
Subject Re: Review Request 48291: Use varint comparator in replica log.
Date Thu, 09 Jun 2016 19:21:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48291/#review136876
-----------------------------------------------------------



make check passed.
I guess there are already test cases that cover this change.

- Bing Li


On June 6, 2016, 7:54 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48291/
> -----------------------------------------------------------
> 
> (Updated June 6, 2016, 7:54 p.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent huang.
> 
> 
> Bugs: MESOS-970
>     https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since bug discussed at
> https://groups.google.com/forum/#!topic/leveldb/F-rDkWiQm6c
> was fixed. After upgrading leveldb to 1.18 we could replace
> default byte-wise comparator with varint comparator.
> 
> 
> Diffs
> -----
> 
>   src/log/leveldb.cpp f389d74b123574665c611b46cb52e3dc7042b331 
> 
> Diff: https://reviews.apache.org/r/48291/diff/
> 
> 
> Testing
> -------
> 
> `make check dist` on Ubuntu x64
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message