mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.
Date Thu, 09 Jun 2016 18:12:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48438/#review136864
-----------------------------------------------------------



Looks great to me. XD


include/mesos/v1/mesos.proto (lines 1974 - 1976)
<https://reviews.apache.org/r/48438/#comment201942>

    Should be required? According to
    
    ```
    static void json(JSON::ObjectWriter* writer, const Summary<Slave>& summary)
    {
      const Slave& slave = summary;
    
      writer->field("id", slave.id.value());
      writer->field("pid", string(slave.pid));
      writer->field("hostname", slave.info.hostname());
      writer->field("registered_time", slave.registeredTime.secs());
    
      if (slave.reregisteredTime.isSome()) {
        writer->field("reregistered_time", slave.reregisteredTime.get().secs());
      }
    ```



include/mesos/v1/mesos.proto (lines 1983 - 1984)
<https://reviews.apache.org/r/48438/#comment201943>

    Same questions about optional here.


- haosdent huang


On June 8, 2016, 6:37 p.m., zhou xing wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48438/
> -----------------------------------------------------------
> 
> (Updated June 8, 2016, 6:37 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: mesos-5491
>     https://issues.apache.org/jira/browse/mesos-5491
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implement the basic getAgents method for v1 operator master API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 
>   include/mesos/v1/mesos.proto 39967fa09d2774d564f3df28277edea8ebcfb50d 
>   src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 
>   src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840 
>   src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 
>   src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48438/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> zhou xing
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message