mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.
Date Thu, 09 Jun 2016 17:46:40 GMT


> On June 6, 2016, 10:21 p.m., Joseph Wu wrote:
> > src/tests/api_tests.cpp, lines 266-269
> > <https://reviews.apache.org/r/48259/diff/1/?file=1406743#file1406743line266>
> >
> >     Why don't you evolve/devolve here?

@kaysoky, thanks a lot for your review. Because we define

```
v1::master::Response evolve(const maintenance::Schedule& schedule)
```

in evolve.cpp, could not define it and return `v1::maintenance::ClusterStatus` again.


It is not nice here, do you have any suggestions to avoid this? How about rename `v1::master::Response
evolve(const maintenance::Schedule& schedule)` to `v1::master::Response evolveToResponse(const
maintenance::Schedule& schedule)`. Or to create a help routine in api_tests.cpp?


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48259/#review136372
-----------------------------------------------------------


On June 9, 2016, 5:32 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48259/
> -----------------------------------------------------------
> 
> (Updated June 9, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5504
>     https://issues.apache.org/jira/browse/MESOS-5504
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48259/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message