mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 48299: Updated balloon framework spacing and logging.
Date Tue, 07 Jun 2016 21:11:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48299/#review136540
-----------------------------------------------------------


Fix it, then Ship it!





src/examples/balloon_framework.cpp (lines 52 - 53)
<https://reviews.apache.org/r/48299/#comment201601>

    IIRC for constructors we use the format on the left.



src/examples/balloon_framework.cpp (line 173)
<https://reviews.apache.org/r/48299/#comment201602>

    ..lost on agent..


- Vinod Kone


On June 6, 2016, 11:51 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48299/
> -----------------------------------------------------------
> 
> (Updated June 6, 2016, 11:51 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.
> 
> 
> Bugs: MESOS-5174
>     https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes some whitespace for the balloon framework and
> changes most logging messages to use glog.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 739fb504e93154bf032b4c621151fa3c99b60037 
> 
> Diff: https://reviews.apache.org/r/48299/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message