mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.
Date Tue, 07 Jun 2016 16:42:35 GMT


> On June 6, 2016, 1:38 p.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 150-156
> > <https://reviews.apache.org/r/45574/diff/7/?file=1347676#file1347676line150>
> >
> >     I see in this hashmap, the keys and values are exactly same, e.g., CGROUP_SUBSYSTEM_CPU_NAME
is "cpu", CGROUP_SUBSYSTEM_CPUACCT_NAME is "cpuacct", etc. It is a bit strange to have same
keys and values in a hashmap, maybe we should use hashset?

Because we want to map 'mem' -> 'memory', we could not use hashet here. Currently `CgroupsMemIsolatorProcess`
use `cgroups/mem` as isolation flag. However, the memory subsystem name in Linux us `memory`.
So we need to map `mem` -> `memory`.

And I think we may have other inconsistent between our internal name and Linux cgroup subsystem
name, e.g. `devices/gpu` -> `devices`. So I think it is necessary.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45574/#review136248
-----------------------------------------------------------


On April 16, 2016, 10:28 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45574/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 10:28 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and Kevin Klues.
> 
> 
> Bugs: MESOS-5047
>     https://issues.apache.org/jira/browse/MESOS-5047
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add `PerfEventSubsystem` for cgroups unified isolator.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.hpp 674d5f886ea41b939a8e48832ee6595a78b2f6ce 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45574/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message