mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Artem Harutyunyan <ar...@mesosphere.io>
Subject Re: Review Request 46626: Added example framework for testing disk quota enforcement.
Date Tue, 07 Jun 2016 16:17:03 GMT


> On May 27, 2016, 6 p.m., Joseph Wu wrote:
> > src/examples/disk_full_framework.cpp, line 171
> > <https://reviews.apache.org/r/46626/diff/1/?file=1359466#file1359466line171>
> >
> >     What's the importance of this sleep after the disk ramp-up?  And would it make
sense for this sleep to be configurable too?

Done. Thanks.


> On May 27, 2016, 6 p.m., Joseph Wu wrote:
> > src/examples/disk_full_framework.cpp, lines 237-238
> > <https://reviews.apache.org/r/46626/diff/1/?file=1359466#file1359466line237>
> >
> >     Consider omitting the `default:`, or aborting in this case.

I either need to have the default, or explicitly list the missing task states. If we list
states explicitly the code won't compile without modifications in case we introduce a new
state. Maybe it's a good thing. What do you think? I am open to suggestsions. 
And what do you mean by abort? Exiting the framework?


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46626/#review134863
-----------------------------------------------------------


On June 7, 2016, 9:10 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46626/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 9:10 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added example framework for testing disk quota enforcement.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am a08ea407d631f6ae56ac36b122bfdf0e849e8b56 
>   src/examples/disk_full_framework.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46626/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message