mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos ReviewBot <revi...@mesos.apache.org>
Subject Re: Review Request 48344: Parameterized partition tests with registry "strictness".
Date Tue, 07 Jun 2016 15:08:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48344/#review136470
-----------------------------------------------------------



Patch looks great!

Reviews applied: [48248, 48249, 48250, 48342, 48343, 48344]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On June 7, 2016, 1:45 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48344/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jan Schlicht, and Vinod Kone.
> 
> 
> Bugs: MESOS-5547
>     https://issues.apache.org/jira/browse/MESOS-5547
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We should test that the same partition behavior is implemented
> for both strict and non-strict registry configurations.
> 
> 
> Diffs
> -----
> 
>   src/tests/partition_tests.cpp 956493d5b2fb531dcedc477b2fdbbc0609e01412 
> 
> Diff: https://reviews.apache.org/r/48344/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Also manually modified the master in a way that breaks non-strict registry slave removal
behavior (by never inserting into the `slaves.removed` collection in the master) and verified
that these test do _not_ break in master but they _do_ break after this patch is applied.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message