mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 48344: Parameterized partition tests with registry "strictness".
Date Tue, 07 Jun 2016 13:45:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48344/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler, Jan Schlicht, and Vinod Kone.


Bugs: MESOS-5547
    https://issues.apache.org/jira/browse/MESOS-5547


Repository: mesos


Description
-------

We should test that the same partition behavior is implemented
for both strict and non-strict registry configurations.


Diffs
-----

  src/tests/partition_tests.cpp 956493d5b2fb531dcedc477b2fdbbc0609e01412 

Diff: https://reviews.apache.org/r/48344/diff/


Testing
-------

make check

Also manually modified the master in a way that breaks non-strict registry slave removal behavior
(by never inserting into the `slaves.removed` collection in the master) and verified that
these test do _not_ break in master but they _do_ break after this patch is applied.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message