mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.
Date Mon, 06 Jun 2016 22:21:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48259/#review136372
-----------------------------------------------------------




src/tests/api_tests.cpp (lines 265 - 268)
<https://reviews.apache.org/r/48259/#comment201393>

    Why don't you evolve/devolve here?



src/tests/api_tests.cpp (lines 294 - 299)
<https://reviews.apache.org/r/48259/#comment201394>

    Why not use evolve/devolve and compare protobufs directly?


- Joseph Wu


On June 5, 2016, 11:02 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48259/
> -----------------------------------------------------------
> 
> (Updated June 5, 2016, 11:02 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5504
>     https://issues.apache.org/jira/browse/MESOS-5504
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 
> 
> Diff: https://reviews.apache.org/r/48259/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message