mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 47808: Added test for parsing docker config.
Date Mon, 06 Jun 2016 20:56:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47808/#review136360
-----------------------------------------------------------




src/tests/containerizer/docker_spec_tests.cpp (line 237)
<https://reviews.apache.org/r/47808/#comment201382>

    I would split this test into two tests, one for old format and one for new format.


- Jie Yu


On May 25, 2016, 1:33 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47808/
> -----------------------------------------------------------
> 
> (Updated May 25, 2016, 1:33 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4938
>     https://issues.apache.org/jira/browse/MESOS-4938
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for parsing docker config.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_spec_tests.cpp 796b020f58f8451362bc1357ab6d7ceb4e946b3c

> 
> Diff: https://reviews.apache.org/r/47808/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message