mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 47929: Libprocess: made standalone build work again.
Date Sat, 04 Jun 2016 21:18:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47929/#review136196
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/Makefile.am (lines 1 - 15)
<https://reviews.apache.org/r/47929/#comment201210>

    Wrong header, please use the "Apache License Version 2.0" header instead:
    
    ```
     // Licensed under the Apache License, Version 2.0 (the "License");  
     // you may not use this file except in compliance with the License.  
     // You may obtain a copy of the License at  
     //  
     //     http://www.apache.org/licenses/LICENSE-2.0  
     //  
     // Unless required by applicable law or agreed to in writing, software  
     // distributed under the License is distributed on an "AS IS" BASIS,  
     // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  
     // See the License for the specific language governing permissions and  
     // limitations under the License
    ```



3rdparty/libprocess/3rdparty/gmock_sources.cc.in (line 1)
<https://reviews.apache.org/r/47929/#comment201211>

    Wrong header, use the "Apache License Version 2.0" header.


- Till Toenshoff


On May 26, 2016, 11:30 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47929/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 11:30 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-5415
>     https://issues.apache.org/jira/browse/MESOS-5415
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Libprocess: made standalone build work again.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am PRE-CREATION 
>   3rdparty/libprocess/3rdparty/gmock_sources.cc.in PRE-CREATION 
>   3rdparty/libprocess/Makefile.am 3c3249fe9799ba919ac7bd13e2ddb07a306737f0 
>   3rdparty/libprocess/configure.ac 2daded51122ab97d71ec57109b85c2473460eeda 
> 
> Diff: https://reviews.apache.org/r/47929/diff/
> 
> 
> Testing
> -------
> 
> The following passes from within 3rdparty/libprocess:
> ./bootstrap && mkdir build && cd build && ../configure &&
make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message